Skip to content

docs(backend): document backend support and workflows - #5929

Open
njzjz wants to merge 12 commits into
deepmodeling:masterfrom
njzjz:docs/5919-backends
Open

docs(backend): document backend support and workflows#5929
njzjz wants to merge 12 commits into
deepmodeling:masterfrom
njzjz:docs/5919-backends

Conversation

@njzjz

@njzjz njzjz commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

Closes #5919.
Closes #5920.
Closes #5923.
Supersedes #5930.

Validation

  • ruff format .
  • ruff check .
  • uvx pre-commit run mdformat --files ... for all changed Markdown files
  • dp --dp compress --help
  • dp --jax compress --help
  • git diff --check

Coding agent: Codex
Codex version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning effort: xhigh

Summary by CodeRabbit

  • Documentation
    • Expanded backend guidance for training, freezing, compression, conversion, and inference, including TensorFlow 2, PyTorch-Exportable, JAX, Paddle, and DP.
    • Added backend selection commands, workflow examples, multi-task checkpoint selection, and Hessian-enabled JAX freezing.
    • Documented backend-specific file formats, export artifacts, ABI selection, optional TensorFlow 2 JIT compilation, and feature limitations.
    • Updated model pages with corrected backend support, spin and graph-native inference guidance, and standardized command syntax.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
Copilot AI lite review requested due to automatic review settings July 29, 2026 15:10
@dosubot dosubot Bot added the Docs label Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Documentation now covers seven backends, including TensorFlow 2 and PyTorch-Exportable, across backend selection, training, freezing, compression, model formats, inference detection, and Hessian handling.

Changes

Backend documentation

Layer / File(s) Summary
Backend reference and selection
doc/backend.md
Lists supported backends, documents TensorFlow 2, PyTorch-Exportable, and JAX formats and capabilities, and expands backend selection and inference detection guidance.
Training, freezing, and compression workflows
doc/train/training.md, doc/freeze/freeze.md, doc/freeze/compress.md
Adds backend-specific commands, output formats, lowering options, compression routes, Hessian options, and multi-task guidance.
Model backend and descriptor support
doc/model/*.md
Updates backend coverage, descriptor limitations, pairwise support, export command spelling, and spin data guidance.
Hessian preservation guidance
doc/model/overall.md, doc/model/train-energy-hessian.md
Documents PyTorch Hessian limitations and JAX Hessian-preserving freeze behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • Issue 5917: Covers the broader backend, JAX training, compression, and Hessian documentation.
  • Issue 5920: Directly overlaps with the JAX training, freeze, and Hessian documentation.
  • Issue 5923: Directly overlaps with backend compression documentation.

Possibly related PRs

Suggested reviewers: iprozd, wanghan-iapcm

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the documentation changes for backend support and workflows.
Linked Issues check ✅ Passed The documentation covers TF2, PyTorch-Exportable, JAX training and Hessian freezing, plus DP and JAX compression objectives.
Out of Scope Changes check ✅ Passed The documentation and backend-icon updates support the stated backend workflow, capability, limitation, and routing objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@doc/train/training.md`:
- Line 23: Remove the shell prompt marker from each command-only example, or add
corresponding output, to eliminate MD014 warnings: update the TensorFlow 2,
PyTorch, and PyTorch-Exportable examples at doc/train/training.md lines 23, 30,
and 37, and the TensorFlow 2 and PyTorch-Exportable examples at
doc/freeze/freeze.md lines 21 and 52.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 16cb4b9c-60c4-416c-bbc6-ec382d110acd

📥 Commits

Reviewing files that changed from the base of the PR and between 721f586 and 7a94be5.

📒 Files selected for processing (4)
  • doc/backend.md
  • doc/freeze/compress.md
  • doc/freeze/freeze.md
  • doc/train/training.md

Comment thread doc/train/training.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds user-facing documentation for selecting and using the TensorFlow 2 (eager) and PyTorch-Exportable (pt-expt) backends, covering backend selection plus train, freeze, and compress CLI usage across the relevant docs pages.

Changes:

  • Add TF2 and PyTorch-Exportable tabs to the training instructions.
  • Add TF2 and PyTorch-Exportable tabs to the freeze and compress docs (including --lower-kind mention for pt-expt).
  • Extend doc/backend.md to include the two backends, their model/checkpoint formats, and inference suffix detection notes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
doc/backend.md Adds TF2 and PyTorch-Exportable backend documentation (selection, file formats, detection).
doc/train/training.md Adds TF2 and PyTorch-Exportable training command tabs.
doc/freeze/freeze.md Adds TF2 and PyTorch-Exportable freeze command tabs and notes.
doc/freeze/compress.md Updates supported-backends note and adds TF2 / PyTorch-Exportable compress tabs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread doc/freeze/freeze.md Outdated
Comment thread doc/freeze/freeze.md Outdated
Comment thread doc/freeze/compress.md Outdated
njzjz-bot added 2 commits July 29, 2026 23:24
Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
Document TF2, PyTorch-Exportable, and JAX availability across model and descriptor guides, and add DP/JAX compression routes.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
Copilot AI review requested due to automatic review settings July 29, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@njzjz njzjz changed the title docs(backend): document TF2 and PyTorch-Exportable backends docs(backend): document backend support and workflows Jul 29, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
doc/backend.md (1)

114-117: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Document the DPA4 .pt2 ABI, not just the filename classification.

doc/model/dpa4.md documents dp --pt freeze for DPA4 and doc/backend.md says .pt2 belongs to PyTorch-Exportable. The code docs show these pt .pt2 artifacts are AOTInductor, but both ABIs can be classified as .pt2, while the PT and pt_expt code paths/ABI are distinct. Make the inference guidance explicit about “which .pt2” or rename/correct one contract to avoid loading the wrong graph type.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@doc/backend.md` around lines 114 - 117, Update the `.pt2` inference guidance
in the backend documentation to distinguish DPA4 `dp --pt freeze` artifacts from
PyTorch-Exportable/AOTInductor artifacts, explicitly identifying which ABI each
`.pt2` file uses. Align the wording with the separate PT and pt_expt code paths
so users do not load a `.pt2` graph through the wrong backend contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@doc/model/train-fitting-dos.md`:
- Around line 4-11: Update the DOS training documentation to cover TensorFlow 2
and PyTorch-Exportable routes alongside the existing dp --tf train and dp --pt
train examples, adding dp --tf2 train and dp --pt-expt train tabs. If either
backend cannot train DOS models, instead revise the supported-backends
description to explicitly mark it as conversion/inference-only, consistent with
JAX.

---

Outside diff comments:
In `@doc/backend.md`:
- Around line 114-117: Update the `.pt2` inference guidance in the backend
documentation to distinguish DPA4 `dp --pt freeze` artifacts from
PyTorch-Exportable/AOTInductor artifacts, explicitly identifying which ABI each
`.pt2` file uses. Align the wording with the separate PT and pt_expt code paths
so users do not load a `.pt2` graph through the wrong backend contract.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b1880b6-d0b4-460d-b54d-d31775212ee3

📥 Commits

Reviewing files that changed from the base of the PR and between 7a94be5 and 1cb0fa8.

📒 Files selected for processing (24)
  • doc/backend.md
  • doc/freeze/compress.md
  • doc/freeze/freeze.md
  • doc/model/dpa2.md
  • doc/model/dpa3.md
  • doc/model/dpa4.md
  • doc/model/dprc.md
  • doc/model/linear.md
  • doc/model/overall.md
  • doc/model/pairtab.md
  • doc/model/train-energy-hessian.md
  • doc/model/train-energy-spin.md
  • doc/model/train-energy.md
  • doc/model/train-fitting-dos.md
  • doc/model/train-fitting-property.md
  • doc/model/train-fitting-tensor.md
  • doc/model/train-hybrid.md
  • doc/model/train-se-atten.md
  • doc/model/train-se-e2-a-tebd.md
  • doc/model/train-se-e2-a.md
  • doc/model/train-se-e2-r.md
  • doc/model/train-se-e3-tebd.md
  • doc/model/train-se-e3.md
  • doc/train/training.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • doc/freeze/compress.md

Comment thread doc/model/train-fitting-dos.md Outdated
Document the distinct .pt2 lower-input ABIs and add the missing DOS training commands for TensorFlow 2 and PyTorch-Exportable.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
Copilot AI review requested due to automatic review settings July 29, 2026 16:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Document the dense nlist exception used by PT-frozen deepspin DPA4 models.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
Copilot AI review requested due to automatic review settings July 29, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.28%. Comparing base (6330a2f) to head (23a87ad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5929      +/-   ##
==========================================
- Coverage   79.53%   79.28%   -0.25%     
==========================================
  Files        1075     1075              
  Lines      126134   126134              
  Branches     4592     4598       +6     
==========================================
- Hits       100315   100004     -311     
- Misses      24164    24477     +313     
+ Partials     1655     1653       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wanghan-iapcm wanghan-iapcm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a large and mostly accurate sweep -- I checked the great majority of the new support claims against backend registration at head and they hold up, including the ones that are easy to get wrong. Specifically confirmed correct: every dp --tf2 / dp --pt-expt / dp --jax flag against the aliases in deepmd/backend/*.py; the dp --pt_expt to dp --pt-expt and .xlo to .hlo corrections (both were real doc bugs); all the frozen-model suffixes against each backend's suffixes; dp --jax freeze --hessian; the JAX energy-loss-only and no---init-frz-model caveats; the TF2 and Paddle additions on dpa2/dpa3/se_e3_tebd; and the DPA4 note, where JAX really does have deepmd/jax/descriptor/dpa4.py but no jax/model/dpa4_model.py, so "descriptor-only" is exactly right.

Two claims do not hold. Both are inline.

One smaller thing I did not raise inline. The Hessian rewording in overall.md and train-energy-hessian.md is not wrong -- it names dp --pt freeze and the TorchScript route specifically -- but hessian_mode is honored only at deepmd/pt/model/model/__init__.py#L371-L374, and neither pt_expt/model/get_model.py nor dpmodel/model/model.py mention it, so PyTorch-Exportable cannot construct a Hessian model at all. Since this PR establishes that {{ pytorch_icon }} covers both, the page is now silent on pt_expt where it used to be blanket. Worth a clause if you touch these lines again; not worth a round trip on its own.

Comment thread doc/model/pairtab.md Outdated
Comment thread doc/freeze/compress.md Outdated

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current DPA4 native-spin multi-rank guidance contradicts both the implementation and itself. The graph-route/native-spin section of doc/model/dpa4.md says that native-spin .pt2 archives carry no with-comm artifact, have has_comm_artifact=false, and are single-rank only. At this head, _needs_with_comm_artifact explicitly admits a graph-lowered NativeSpinModelKind whose descriptor communicates across ranks; test_native_spin_needs_with_comm_on_the_graph_lower_only asserts that behavior; and DeepSpinPTExpt loads and dispatches forward_lower_with_comm.pt2 for multi-rank graph native spin. The same page also correctly states near the earlier multi-rank overview and the Limitations section that pt_expt native spin supports multi-rank. Please remove or update the obsolete single-rank paragraphs so this page documents one contract that matches the current export and C++ runtime.

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented PyTorch-Exportable compression workflow does not actually put a compressed model into the executable artifact for the ordinary .pte example. Except for the special fused DPA1 graph .pt2 branch, enable_compression passes the original uncompressed model dictionary to deserialize_to_file and stores the compressed dictionary only as model_json_override. DeepEval reconstructs that model.json object for metadata and introspection, but energy inference runs exported_module or _pt2_runner, so the tabulated model is not executed. I reproduced the documented se_e2_a-style .pte workflow locally: the input and output exported graphs were identical (711 nodes each), the output executable contained no tabulate_fusion operator, while only model.json contained the compression state. Therefore model-compress.pte provides no compression speed or memory benefit even though this page and backend.md present pt_expt compression as generally supported. Please either export the genuinely compressed executable or document the narrow supported case instead of advertising the ordinary .pte workflow as compressed.

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly documented JAX .jax frozen-model route is not usable by the normal DeePMD inference/test interface. Please correct the format contract or implement the missing loader support.

Comment thread doc/backend.md Outdated

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly documented TensorFlow 2 compression workflow fails for the normalized default se_e2_a configuration. The implementation or the documented support contract needs to be corrected.

Comment thread doc/freeze/compress.md
wanghan-iapcm
wanghan-iapcm previously approved these changes Aug 1, 2026

@wanghan-iapcm wanghan-iapcm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both points are addressed, and I checked the files at 3bc4ff06a rather than taking the replies at their word.

On the pairtab page: Paddle is gone from the title and from both notes, and DP is back on the linear-combination note and on linear.md. Since the fix introduced a claim I had not checked in the first round, I verified it too — the new "PyTorch-Exportable" on both lines holds, because deepmd/pt_expt/model/ carries both dp_zbl_model.py and dp_linear_model.py. The asymmetry between the two notes is also right rather than an oversight: JAX and TF2 appear on the short-range interpolation line, where each has pairtab_atomic_model.py and dp_zbl_model.py, but not on the linear-combination line, where neither has a dp_linear_model.py — only linear_atomic_model.py. And Paddle genuinely has none of them.

On the compression page: switching the headline example to -i frozen_model.jax -o compressed_model.jax removes the case that would have raised. The prose now points at .jax as the general lossless path and defers the StableHLO question to the descriptor pages; I confirmed that deferral is not a dead pointer, since train-se-e2-a.md and train-se-atten.md both state the type_one_side requirement for .hlo export. One small thing for the record only: your reply said the type_one_side requirement was documented for compressed .hlo export, and in compress.md itself it is referred out rather than stated. That is the better placement given the requirement is descriptor-specific, so I am not asking for a change — just noting the wording difference in case you expected it inline.

The Hessian point from my earlier review body is resolved as well. train-energy-hessian.md now says "Supported backends: PyTorch-TorchScript, JAX" and labels the tabs the same way, instead of the blanket PyTorch icon. That matches where hessian_mode is actually honored — deepmd/pt/, deepmd/jax/, and deepmd/dpmodel/model/make_hessian_model.py, with nothing on the pt_expt side — so the page no longer implies coverage that does not exist.

@wanghan-iapcm wanghan-iapcm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both points are addressed, and I checked the files at 3bc4ff06a rather than taking the replies at their word.

On the pairtab page: Paddle is gone from the title and from both notes, and DP is back on the linear-combination note and on linear.md. Since the fix introduced a claim I had not checked in the first round, I verified it too — the new "PyTorch-Exportable" on both lines holds, because deepmd/pt_expt/model/ carries both dp_zbl_model.py and dp_linear_model.py. The asymmetry between the two notes is also right rather than an oversight: JAX and TF2 appear on the short-range interpolation line, where each has pairtab_atomic_model.py and dp_zbl_model.py, but not on the linear-combination line, where neither has a dp_linear_model.py — only linear_atomic_model.py. And Paddle genuinely has none of them.

On the compression page: switching the headline example to -i frozen_model.jax -o compressed_model.jax removes the case that would have raised. The prose now points at .jax as the general lossless path and defers the StableHLO question to the descriptor pages; I confirmed that deferral is not a dead pointer, since train-se-e2-a.md and train-se-atten.md both state the type_one_side requirement for .hlo export. One small thing for the record only: your reply said the type_one_side requirement was documented for compressed .hlo export, and in compress.md itself it is referred out rather than stated. That is the better placement given the requirement is descriptor-specific, so I am not asking for a change — just noting the wording difference in case you expected it inline.

The Hessian point from my earlier review body is resolved as well. train-energy-hessian.md now says "Supported backends: PyTorch-TorchScript, JAX" and labels the tabs the same way, instead of the blanket PyTorch icon. That matches where hessian_mode is actually honored — deepmd/pt/, deepmd/jax/, and deepmd/dpmodel/model/make_hessian_model.py, with nothing on the pt_expt side — so the page no longer implies coverage that does not exist.

@wanghan-iapcm
wanghan-iapcm dismissed stale reviews from themself August 1, 2026 10:12

Duplicate submission on my side; superseded by the identical approval below.

Comment thread doc/model/dpa4.md Outdated
Comment thread doc/model/dpa4.md Outdated
DPA4/SeZM is realized in the PyTorch backend but exports through the
AOTInductor .pt2 path, not TorchScript. The backend rename to
PyTorch-TorchScript was mechanically applied to this page earlier; restore
accurate wording in the quick-start and freeze-to-.pt2 sections.

Coding-Agent: opencode
opencode-Version: 1.18.9
Model: ustc/deepseek-v4-flash
Reasoning-Effort: max
Copilot AI review requested due to automatic review settings August 2, 2026 15:41
@njzjz
njzjz requested a review from OutisLi August 2, 2026 15:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated no new comments.

Suppressed comments (3)

doc/troubleshooting/howtoset_num_nodes.md:20

  • This section attributes the torchrun-based distributed training workflow only to the PyTorch-TorchScript backend, but the PyTorch-Exportable backend also initializes distributed training when launched via torchrun/srun (pt_expt entrypoint). Consider wording that covers both backends to avoid implying dp --pt-expt train cannot be launched with torchrun.
    doc/train/parallel-training.md:98
  • This section title and opening sentence scope DDP/torchrun parallel training to the PyTorch-TorchScript backend, but the PyTorch-Exportable backend also supports torchrun-launched distributed training. Updating the heading/intro to include both helps keep the backend documentation consistent.
## PyTorch-TorchScript Implementation {{ pytorch_icon }}

Currently, parallel training in pytorch version is implemented in the form of PyTorch Distributed Data Parallelism [DDP](https://pytorch.org/docs/stable/generated/torch.nn.parallel.DistributedDataParallel.html).
DeePMD-kit will decide whether to launch the training in parallel (distributed) mode or in serial mode depending on your execution command.

doc/model/train-se-e2-r.md:79

  • type_one_side=false is also unsupported in the PyTorch-Exportable backend for se_e2_r (pt_expt uses the dpmodel se_r implementation, which raises NotImplementedError when type_one_side is false). The backend list here should include PyTorch-Exportable as well.
In the TensorFlow backend, {ref}`env_protection <model[standard]/descriptor[se_e2_r]/env_protection>` cannot be set to a non-zero value.
In the PyTorch-TorchScript, JAX, and DP backends, {ref}`type_one_side <model[standard]/descriptor[se_e2_r]/type_one_side>` cannot be set to `false`.

@iProzd iProzd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the current head after the DPA4/SeZM follow-up. The documentation now correctly separates the dp --pt training route from the AOTInductor .pt2 export/runtime path and explicitly states that DPA4/SeZM does not use ordinary TorchScript. The prior backend-contract concerns are resolved, and I found no new blocking issue.

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remaining backend-classification error is noted inline.

Comment thread doc/backend.md Outdated

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional backend-workflow omission is noted inline.

Comment thread doc/model/change-bias.md Outdated

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional PyTorch-Exportable training-workflow omission is noted inline.

Comment thread doc/train/parallel-training.md

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional graph-freeze behavior mismatch is noted inline.

Comment thread doc/model/dpa2.md

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional backend-workflow documentation gap is noted inline.

Comment thread doc/backend.md

@OutisLi OutisLi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional spin-scheme semantic mismatch is noted inline.

Comment thread doc/model/train-energy-spin.md Outdated
njzjz-bot added 2 commits August 4, 2026 10:42
# Conflicts:
#	doc/model/train-se-atten.md
Reply and close the current review round on deepmodeling#5929:

- backend.md: describe the DPA4/SeZM `dp --pt freeze` export as the
  separate AOTInductor route instead of a PyTorch-TorchScript route, so
  the overview agrees with dpa4.md.
- change-bias.md: document the PyTorch-Exportable `dp --pt-expt
  change-bias` route for .pt/.pte/.pt2 inputs, with the multi-task
  limitation noted.
- parallel-training.md: add the PyTorch-Exportable DDP subsection with a
  `torchrun ... dp --pt-expt train` example, separate from the
  PyTorch-TorchScript ZeRO/FSDP2 section.
- dpa2.md: drop the unavailable dense (`nlist`, default) fallback advice
  and state the forced graph lower for graph-eligible DPA-2.
- finetuning.md: document the TensorFlow 2 and PyTorch-Exportable
  `--finetune` workflows and their accepted formats/limitations.
- train-energy-spin.md: scope the virtual-atom (sel-extension) guidance
  to the deepspin scheme, add the DPA4 native exception, and add DPA4 to
  the scheme-aware supported-descriptor list.

Coding-Agent: opencode
opencode-Version: 1.18.11
Model: ustc/deepseek-v4-flash
Reasoning-Effort: max
Copilot AI review requested due to automatic review settings August 4, 2026 03:16
@njzjz-bot

Copy link
Copy Markdown
Contributor

Addressed the current round of review feedback in 708891e and merged latest master (resolving the merge conflict):

  • backend.md: the DPA4/SeZM dp --pt freeze export is described as the separate AOTInductor route (not PyTorch-TorchScript), consistent with dpa4.md.
  • change-bias.md: documented the PyTorch-Exportable dp --pt-expt change-bias route for .pt/.pte/.pt2 inputs and its multi-task limitation.
  • parallel-training.md: added a PyTorch-Exportable DDP subsection (torchrun ... dp --pt-expt train) separate from the PyTorch-TorchScript ZeRO/FSDP2 section.
  • dpa2.md: removed the unavailable dense (nlist)-fallback advice; stated that graph-eligible DPA-2 freezes only through the graph lower.
  • finetuning.md: documented TensorFlow 2 and PyTorch-Exportable --finetune workflows with their accepted formats and limitations.
  • train-energy-spin.md: scoped the virtual-atom/sel-extension guidance to the deepspin scheme, added the DPA4 native exception, and added DPA4 to the scheme-aware descriptor list.

All review threads replied to inline and resolved. Validation: mdformat passed on all changed files, pytest source/tests/common/test_argcheck_backend_docs.py passed.

Coding agent: opencode
opencode version: 1.18.11
Model: ustc/deepseek-v4-flash
Reasoning effort: max

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated no new comments.

Suppressed comments (1)

doc/freeze/compress.md:122

  • The DP compression note omits the .yml DPModel format. deepmd.dpmodel.utils.serialization.load_dp_model() explicitly supports both .yaml and .yml, so the docs should list both to avoid implying .yml inputs are unsupported.
DP compression accepts native `.dp` and `.yaml` models.

- compress.md: list `.yml` alongside `.dp`/`.yaml` for DP compression,
  matching load_dp_model's supported extensions.
- train-se-e2-r.md: include PyTorch-Exportable in the backends for which
  `type_one_side=false` is unsupported (pt_expt `se_r` inherits the
  dpmodel implementation that raises NotImplementedError).
- howtoset_num_nodes.md: note that torchrun-based multiprocessing
  training applies to both PyTorch-TorchScript and PyTorch-Exportable.

Coding-Agent: opencode
opencode-Version: 1.18.11
Model: ustc/deepseek-v4-flash
Reasoning-Effort: max
Copilot AI review requested due to automatic review settings August 4, 2026 03:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated no new comments.

Suppressed comments (3)

doc/train/finetuning.md:5

  • The supported-backends note omits PyTorch-Exportable even though this page now documents a PyTorch-Exportable fine-tuning workflow below. This is misleading for readers scanning the page header; list both PyTorch variants here for consistency with the rest of the backend docs.
> **Supported backends**: TensorFlow {{ tensorflow_icon }}, TensorFlow 2
> {{ tensorflow_icon }}, PyTorch {{ pytorch_icon }}, Paddle {{ paddle_icon }}

doc/model/train-energy-hessian.md:118

  • This warning states that PyTorch-Exportable cannot construct a Hessian model for freezing or inference, but the codebase includes explicit pt_expt Hessian-model support (e.g. deepmd/pt_expt/model/ener_model.py has enable_hessian() and there are pt_expt Hessian tests). The doc should not make an absolute “cannot construct” claim here; at minimum, remove the pt-expt sentence or replace it with a precise, verified limitation about export/freeze behavior.
> The PyTorch-TorchScript freeze route does not preserve Hessian output. A
> PyTorch-TorchScript model frozen with `dp --pt freeze` is treated as a
> standard energy model. PyTorch-Exportable cannot construct a Hessian model
> for freezing or inference. The JAX backend can preserve Hessian output in a
> frozen model with `dp --jax freeze --hessian`.

doc/model/overall.md:64

  • This warning claims PyTorch-Exportable cannot construct a Hessian model for freezing or inference, but pt_expt has Hessian-model support in code/tests (e.g. EnergyModel.enable_hessian() and source/tests/pt_expt/model/test_ener_hessian_model.py). The documentation should not state that pt-expt cannot construct Hessian models; remove or rephrase this sentence to match the implemented behavior.
> The PyTorch-TorchScript freeze route cannot output Hessians, and
> PyTorch-Exportable cannot construct a Hessian model for freezing or
> inference. The JAX backend can retain Hessian output in a frozen model with
> `dp --jax freeze --hessian`; see [Freeze a model](../freeze/freeze.md).

@njzjz
njzjz requested a review from OutisLi August 4, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

6 participants